Client Creation Username/email Missing Error

[Jonathan]

When creating a new client, if the "use email as username" option is chosen and no email address is entered, the error says "please enter a username" which is misleading as it leads one to believe that the "use email as username" option didn't function properly.  Simply stating that the email address wasn't entered would be a much better option here.

 

Rather simple, but caused me to try re-submitting a few times after selecting "use email as username" over and over thinking some AJAX call failed or something then I eventually figured out it meant email was missing.

[Tyson]

the error says "please enter a username" which is misleading as it leads one to believe that the "use email as username" option didn't function properly.  Simply stating that the email address wasn't entered would be a much better option here.

 

Blesta processes user information in a certain order, which is to say the user (with a username) must be created before the client (with the email address), and errors in the former are shown before the latter is attempted, and the type of username (email) is not relevant to that error. I don't see how the "please enter a username" error could be inferred as the "use email as username" option didn't function properly, though.

 

Moving to feature requests.

[Jonathan]

That makes sense, but here's how my mind processed this.

 

1. Fill out the fields I need.  Name, password, use email as username. I legitmiately forgot to fill in the email filled but meant to.
2. Submit.
3. Error "please enter a username".
4. That's weird, there's no field named username, unless it is trying to submit a field that it'd want if I wanted to set a username.
5. Re-toggle off/on use email as username option and try again.
6. Same error, please enter a username.  That's really weird, there's no username field.
7. Oh, well I did miss the email field here, lets fill that in and try again.
8. Success.

It's not a bug so much as it is just an incorrect and misleading error.  There's no field named "username" yet the error tells you it's missing.  Changing this one word to "email" would add a ton of clarification.  I hope my thought process above helps you to understand how I thought it through.  Guess had I not missed the email then this wouldn't be an issue, but then again, the error is there to help you find what you missed so it should be correct.

 

I've attached a screenshot of how I had the form filled out.