Domain Continually Renewing

[flangefrog]

So I've just woken up to a $215 $343 bill from my registrar. Turns out a domain was being renewed every 5min until it hit the 10 year limit. Under what circumstances would Blesta continually renew something like this? Is it possible it could be something to do with my module? It is actually the same service I mentioned in http://www.blesta.com/forums/index.php?/topic/3565-0-invoice-not-paid/ and started renewing after I manually applied the credit to it.

[Tyson]

Blesta would renew a service if the service was a paid pending service ready to be renewed.

 

You may want to check whether the service is still in a pending state, and if not, whether the service renew dates failed to get updated.

[flangefrog]

The service is active and the renewal date was updated correctly.

[Blesta Addons]

is still blesta send renew command ?

[flangefrog]

is still blesta send renew command ?

I commented it out in the module for now, It is probably still calling the renewal method though. I will check.

[Blesta Addons]

uncomment it , and make the function return any string like "renew service success" .

[flangefrog]

Actually I just looked at my logs and it last renewed at 4:55am

[flangefrog]

Ok, the problem is that the date_last_renewed was not updated. This is indirectly related to http://www.blesta.com/forums/index.php?/topic/3565-0-invoice-not-paid/ The $0 credit transaction that I added was not applied to the invoice (that's why the date_last_renewed was not updated) but it did allow the invoice to be marked as paid.
 
I think there should be a safeguard in place, such as the Cron::processRenewingServices() method updating the service's date_last_renewed so this does not ever happen again.

Edit: I'm not sure this is completely correct. What I do know is that Services::getAllRenewablePaid() was returning the service (and still does) until Oct 17, 2014 3:57:45 PM. So it looks like the run_date passed to Services::getAllRenewablePaid() is wrong in Cron::processRenewingServices().

Here is the timeline:

Apr 02, 2014 5:02:54 AM Service added
Sep 21, 2014 5:22:31 PM Service last renewed
Oct 17, 2014 5:05:02 AM Invoice created
Oct 17, 2014 3:57:45 PM Credit applied
Oct 17, 2014 3:57:45 PM Invoice closed
Oct 17, 2014 4:00:03 PM Started renewing every 5 min
Oct 18, 2014 4:56:06 AM Stopped renewing
Nov 21, 2014 6:22:31 PM Service renews

[Blesta Addons]

blesta really need to take care from some incomplete field , do not proccess of some data is not complete or missing .

[Tyson]

Do you purge your cron task logs often? My guess is no, so the date passed to Services::getAllRenewablePaid should be within the last interval for that cron task (last 5 minutes?), so it should only fetch services that were paid (invoice was closed) since that time. You can debug to see if the date is correct.

 

But if you are still receiving that service as a paid renewable service, then it must be an active service with a line item on an invoice that was closed within that interval, otherwise there is something else going on that should be debugged. Have you made any custom changes that might be related to this?

[flangefrog]

Do you purge your cron task logs often? My guess is no, so the date passed to Services::getAllRenewablePaid should be within the last interval for that cron task (last 5 minutes?), so it should only fetch services that were paid (invoice was closed) since that time. You can debug to see if the date is correct.

 

But if you are still receiving that service as a paid renewable service, then it must be an active service with a line item on an invoice that was closed within that interval, otherwise there is something else going on that should be debugged. Have you made any custom changes that might be related to this?

 

No, I don't purge the logs manually. The date from Logs::getCronLastRun() is correct now, but there was a task lock on process renewing services earlier today. This might have something to do with it.

 

I only have a few small core changes as vQmods and I'm confident the changes are not related.

[Tyson]

I think you were right before about the run date being incorrect for Services::getAllRenewablePaid. I think what happened is that the run date (already in UTC) is converted to UTC while it was assuming it was not already in UTC. This advanced the date incorrectly such that each time the cron ran to renew services, your service was erroneously retrieved as renewable, and thus, renewed. This issue is fixed for v3.3.2 as apart of CORE-1500.

[Blesta Addons]

Good found .