Jump to content

Jono

Blesta Developers
  • Posts

    366
  • Joined

  • Last visited

  • Days Won

    36

Jono last won the day on July 15

Jono had the most liked content!

About Jono

Profile Information

  • Gender
    Not Telling

Recent Profile Visitors

2,318 profile views
  1. I've created CORE-4428 to deal with this.
  2. This query should do the trick: UPDATE acl_acl INNER JOIN acl_aco ON acl_aco.id = acl_acl.aco_id SET acl_acl.permission = 'allow' WHERE acl_aco.alias = 'admin_system_staff' AND acl_acl.action = 'editgroup' AND acl_acl.aro_id = 1; Then you can visit admin/settings/system/staff/editgroup/1/ to make sure all appropriate permissions are enabled.
  3. I've created CORE-4412 to address this. In order to patch the current version edit components/invoice_delivery/invoice_delivery.php line 224 from: $this->language, To $invoice->client->settings['language'] ?? $this->language,
  4. I was able to reproduce by performing an upgrade in the admin interface (not able to replicate in client interface). To resolve change app/controllers/admin_clients.php around line 5656 from: $invoice_data = $this->makeInvoice( $client, $serviceChange, $pricing->currency, true, $service->id ); To $invoice_data = $this->makeInvoice( $client, $serviceChange, $pricing->currency, true, null ); Cheers
  5. Here's a video of a basic test that I performed on a 4.10.2 installation. https://www.loom.com/share/40f5cd5005cb4799976f603b5175f1b8 As you can see, a queued upgrade created an invoice with no invoice_lines.service_id set. Do you have any suggestions for what I might do differently to reproduce your issue?
  6. Just want to note here that if you don't sell domains you can remove the client card and nav links for the Domain Manager under Settings > Company > Look and Feel > Layout/Navigation.
  7. This error occurs when the new Domain Manager plugin is not install. To resolve, install the Domain Manager or perform the following code changes: In core/Pricing/Modifier/Type/Description/Type/Domain/Domains.php around line 232 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($package_id); $package = (isset($tld->tld) ? $tld->tld : $package); } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($package_id); $package = (isset($tld->tld) ? $tld->tld : $package); } In core/Pricing/Presenter/Items/Service/ServiceDataItems.php around line 139 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } In core/Pricing/Presenter/Items/Service/ServiceItems.php around line 118 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } }
  8. These upgrades are performed through the core? What version of Blesta are you running? My installation does not link invoice lines from an upgrade to the service through invoice_lines.service_id so I've gotta figure out why yours does.
  9. Thanks for the quick response, I'm headed out of the office, but I'll take a look first thing tomorrow morning. Are you able to identify the invoice for the upgrade in the database and see if the invoice_lines.service_id is set? That seems like the only way this could happen.
  10. I have been unable to reproduce, and looking at the code it shouldn't be possible (either in the latest version or 4.10). Invoices for upgrades do not set the invoice_lines.service_id field. The query to select services to suspend does an inner join on invoice_lines.service_id., so it doesn't seem possible. That being said, I'm definitely willing to test again if you have specific steps to reproduce. If so, please provide
  11. Jono

    tax inclusive

    Happy to report some progress on this via CORE-4294. I had a quick question for those concerned. Should summary/invoice line items show the full price as in this screen shot: Or should they have the tax subtracted as in this screen shot (note that the full price is shown when selecting the items regardless)
  12. Controllers can inherit the ClientController class regardless of whether they are accessed via the client_uri. The ->base_uri is modified, but that shouldn't have an affect on the plugin related links. The only issue would come when a plugin was using ->base_uri to link to a core client controller.
  13. In the core files, the client URI is mapped to client controllers, so for the core it has a purpose. As far as I can tell, it doesn't have a purpose related to plugins, except a visual cue that lets the user know they are in the client interface.
×
×
  • Create New...