PauloV Posted March 17, 2015 Author Report Share Posted March 17, 2015 I just sent you another donation, and anyone who has found your work useful should do the same! Thanks Paul, many thanks for your donations Michael 1 Quote Link to comment Share on other sites More sharing options...
thynan Posted March 17, 2015 Report Share Posted March 17, 2015 I also just made a little donation. You and naja7 are making Blesta work for me. The order process of the OpenSRS modue still has some weird behaviour for me however. I'll be back tomorrow with more questions - time to go to bed now... Hope you don't get tired of me yet.. Blesta Addons and PauloV 2 Quote Link to comment Share on other sites More sharing options...
thynan Posted March 18, 2015 Report Share Posted March 18, 2015 Hi again, I can't get the addon-functionality to work correctly with an OpenSRS package. Has anyone tried this and got it to work? Here's what I did: I created a group called "Webhosting", and an addon group called "Domain Addon". I selected the "Webhosting" group as parent of the "Domain Addon" group. I created 2 packages - one for webhosting which belongs to the "Webhosting" group, and one for domains, using the OpenSRS module, which belongs to the "Domain Addon" group. I created an order form, with the following parameters: Type: Domain and Other Domain Package Group: Webhosting --> I couldnt select the "Domain Addon" group here. Maybe that's the problem? Assigned Package Group: Webhosting When I visit the order form's "domain availability" page, I don't see the checkboxes below the textfield, where I can usually select the available domain-endings. And whenever I enter a domain, I get a "That domain name is not supported" error message. Did I configure something wrong, or does the module just not work as an addon-packge yet? Quote Link to comment Share on other sites More sharing options...
Michael Posted March 18, 2015 Report Share Posted March 18, 2015 Hi again, I can't get the addon-functionality to work correctly with an OpenSRS package. Has anyone tried this and got it to work? Here's what I did: I created a group called "Webhosting", and an addon group called "Domain Addon". I selected the "Webhosting" group as parent of the "Domain Addon" group. I created 2 packages - one for webhosting which belongs to the "Webhosting" group, and one for domains, using the OpenSRS module, which belongs to the "Domain Addon" group. I created an order form, with the following parameters: Type: Domain and Other Domain Package Group: Webhosting --> I couldnt select the "Domain Addon" group here. Maybe that's the problem? Assigned Package Group: Webhosting When I visit the order form's "domain availability" page, I don't see the checkboxes below the textfield, where I can usually select the available domain-endings. And whenever I enter a domain, I get a "That domain name is not supported" error message. Did I configure something wrong, or does the module just not work as an addon-packge yet? Don't do an addon package....! Make an order form... Make it Domain and Other. Select the Domain group via the dropdown box. Then select the hosting packages... That's all you have to do. PauloV 1 Quote Link to comment Share on other sites More sharing options...
atmarcos Posted March 20, 2015 Report Share Posted March 20, 2015 Thanks. I will take a test and then leave feedback. PauloV 1 Quote Link to comment Share on other sites More sharing options...
cleverhost Posted March 25, 2015 Report Share Posted March 25, 2015 PauloV, I finally made good on my promise and sent a donation your way. I hope you can spend a bit more time on this module as I am finally moving new sales over to Blesta very soon, and then my existing customers soon after that, and I only use OpenSRS for domain registration/transfers. Thanks for all your hard work! PauloV 1 Quote Link to comment Share on other sites More sharing options...
PauloV Posted March 25, 2015 Author Report Share Posted March 25, 2015 I also just made a little donation. You and naja7 are making Blesta work for me. The order process of the OpenSRS modue still has some weird behaviour for me however. I'll be back tomorrow with more questions - time to go to bed now... Hope you don't get tired of me yet.. Sorry for the Late Response tynan Many thanks for the Donation PauloV, I finally made good on my promise and sent a donation your way. I hope you can spend a bit more time on this module as I am finally moving new sales over to Blesta very soon, and then my existing customers soon after that, and I only use OpenSRS for domain registration/transfers. Thanks for all your hard work! Many thanks for the Donation cleverhost Today I have finish all pending work (some blesta plugin maide for Blesta Clients ), and now I will continue to update the Modules And Plugins released Tomorow I will start with OpenSRS to add more features like many people has asked me Stay tuned! Quote Link to comment Share on other sites More sharing options...
richwalker Posted April 24, 2015 Report Share Posted April 24, 2015 Hi Paulov How you getting on with the update? Quote Link to comment Share on other sites More sharing options...
PauloV Posted April 24, 2015 Author Report Share Posted April 24, 2015 Hello A couple of more days and I will released Im oping to release on Friday next week Regards, PV Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
dmonaldo Posted May 6, 2015 Report Share Posted May 6, 2015 Hi PauloV, I succesfully installed your module and it works well! I would like to move over several existing domains into Blesta (100+) and was wondering if you had any suggestions. Is there an easy way to import existing domains at OpenSRS into Blesta? Thanks -- dmonaldo Quote Link to comment Share on other sites More sharing options...
PauloV Posted May 8, 2015 Author Report Share Posted May 8, 2015 Hi PauloV, I succesfully installed your module and it works well! I would like to move over several existing domains into Blesta (100+) and was wondering if you had any suggestions. Is there an easy way to import existing domains at OpenSRS into Blesta? Thanks -- dmonaldo Small changes on Blesta Import plugin should import that quickly but maybe Paul/Cody/Tyson could help you on that P.S- im a litle late on releasing the OpenSRS update. I will try to release next week. Sorry all Quote Link to comment Share on other sites More sharing options...
PauloV Posted May 18, 2015 Author Report Share Posted May 18, 2015 sorry guys once again Two weeks ago I was very buisy, and last week I have broke a rib (playing with my son lol), now Im in recovering at wome at least for 3 weeks, so I will try to focus next week on this and finally relase all new funtionality. Sorry all Quote Link to comment Share on other sites More sharing options...
L3Y Posted May 25, 2015 Report Share Posted May 25, 2015 sorry guys once again Two weeks ago I was very buisy, and last week I have broke a rib (playing with my son lol), now Im in recovering at wome at least for 3 weeks, so I will try to focus next week on this and finally relase all new funtionality. Sorry all Hi PauloV, It makes 1 week now How are you going? I hope you are feeling better! I am available to provide feedback on your module whenever you want. We need such module. I encourage you to go ahead on this : there is a lot of peoples waiting such module before they migrate to Blesta! I worked a little on this on my side, but i am not familiar with Blesta / opensrs api. When are you going to release your plugin in stable version? I am asking because it say "while("its FREE")" in your signature, so i assume those are beta plugins/modules? ...are you going to open a module store or something, and then sell your work? Also : should you be available to work on some other projects, please let me know more about your services in pm. Thank you, Carl Quote Link to comment Share on other sites More sharing options...
PauloV Posted May 26, 2015 Author Report Share Posted May 26, 2015 Hello more 48 to 72 hours to the release yes, Im filling much better thanks, the problem was on the first week, now I can bend and Im starting since monday to quicly finish late work to finish this progects Regards, PV Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
PauloV Posted May 29, 2015 Author Report Share Posted May 29, 2015 Hello blestars Here it is new functionality for OpenSRS OpenSRS can now do: Added: [Admin]->[Settings]: Set/Get Registrar Lock Added: [Admin]->[Settings]: Get EPP Code (Transfer Key) Added: [Admin]->[Nameservers]: Set/GET Nameservers Added: [Client]->[Settings]: Set/Get Registrar Lock Added: [Client]->[Settings]: Get EPP Code (Transfer Key) Added: [Client]->[Nameservers]: Set/GET Nameservers Next week I will add: [Admin]->[Whois]: Set/Get Domain Contact Info [Client]->[Whois]: Set/Get Domain Contact Info Please see first post whow to install/upgrade P.S- Sorry about the late release (the late was due the "cokkie" authentication that OpenSRS needs for some commands, and cant be tested on sandbox and was driving me craizy lol) Quote Link to comment Share on other sites More sharing options...
L3Y Posted May 29, 2015 Report Share Posted May 29, 2015 Hi PauloV, I succesfully installed your module and it works well! I would like to move over several existing domains into Blesta (100+) and was wondering if you had any suggestions. Is there an easy way to import existing domains at OpenSRS into Blesta? Thanks -- dmonaldo I guess you need to do this manually, or create an import tool. We used the universal module on our side to migrate, and the Blesta import plugins. PauloV 1 Quote Link to comment Share on other sites More sharing options...
L3Y Posted May 29, 2015 Report Share Posted May 29, 2015 Good work Please : think about adding a button to get the EPP code. I suggest If the user do not click the button, then it won't don't perform the query to get the EPP in the client area. Also : what about a feature to add an email adress corresponding to the current domain? Or maybe you would like create an other module to create an email and update it's password? I think OpenSRS is simply the best provider at this time, and i am happy to see you started back to work on this. Cheers p.s.: On line 11 of openSRS_loader.php, you forgot i think to remove the comment after testing : //define("OPENSRSURI", dirname(__FILE__)); It seems to work even if it's not commented. PauloV 1 Quote Link to comment Share on other sites More sharing options...
PauloV Posted June 1, 2015 Author Report Share Posted June 1, 2015 New Update Optimised in only one core modify file, the patch file for set diferent prices for diferent types:Domain RegisterDomain TransferDomain RenewNow it only needs to modify one file, the [blesta-instalation-folder]/plugins/order/lib/order_types/domain/order_type_domain.phpif you apply the patch files before to set diferent prices for diferent types, you can replace the file [blesta-instalation-folder]/app/models/packages.php with an original file and then apply the new patch file in the first post. adrzei and Blesta Addons 2 Quote Link to comment Share on other sites More sharing options...
L3Y Posted June 1, 2015 Report Share Posted June 1, 2015 Thank you This is going to be useful for other plugins while Blesta dev. complete their work on the new domain functions Someone know when they are going to release the new domain features? I thought it was going to be in a next release, or so? On our side, this was a problem while migrating to Blesta : we were using different prices for renewals, transfer, etc... We ended up by setting a unique price for all our domains, and we are using coupon codes added in the url to provide discounts. It will be much easier if we can get different pricing. ...but in the meantime, it's just more clear for the customer : unique prices. Quote Link to comment Share on other sites More sharing options...
L3Y Posted June 2, 2015 Report Share Posted June 2, 2015 Hi PauloV, We are testing this and saw a problem while changing the dns for a domain. If the domain is locked then OpenSRS will deny any DNS changes. You require to unlock the domain to change the dns settings. But, if you update the dns through the Blesta module it does not return an error while updating the dns if the domain is locked, in the client and admin areas. You need to go to the logs, to see this error : :"Registry error, domain's nameservers not updated [Object status prohibits operation Reason:clientUpdateProhibited]" I suggest to add a message saying something like "This domain must be unlocked to perform dns operations" on the tabClientNameservers if the domain is locked + to return the API error to the customer and the admin. Thank you, Carl PauloV 1 Quote Link to comment Share on other sites More sharing options...
PauloV Posted June 2, 2015 Author Report Share Posted June 2, 2015 I will fix that tomorrow Quote Link to comment Share on other sites More sharing options...
PauloV Posted June 3, 2015 Author Report Share Posted June 3, 2015 New update Fixed: Temporary unlock domain to make changes, and then lock again after changes Added: Better error handeling, displying the direct error message from OPENSRS api on Client and Admin side See first post! Quote Link to comment Share on other sites More sharing options...
L3Y Posted June 15, 2015 Report Share Posted June 15, 2015 Hi Paulov, please note i do not define myself as a developer (i'm a system administrator). ..but i think i saw a couple of problems with the code. Should may want to take a look at this page : http://www-01.ibm.com/support/knowledgecenter/SSUS3D/com.ibm.wbpm.mon.admin.doc/sec/entitlement_system_sample_interface.html?lang=en you will see it seems like you should be using /** * TODO Create an Event to change the Type from domain to domainrenew $package->module_id * OpenSRS 100% completed * Adds the service to the remote server. Sets Input errors on failure, * preventing the service from being added. * * @param stdClass $package A stdClass object representing the selected package * @param array $vars An array of user supplied info to satisfy the request * @param stdClass $parent_package A stdClass object representing the parent service's selected package (if the current service is an addon service) * @param stdClass $parent_service A stdClass object representing the parent service of the service being added (if the current service is an addon service and parent service has already been provisioned) * @param string $status The status of the service being added. These include: * - active * - canceled * - pending * - suspended ...what i can see in the opensrs.php file is : /**TODO Create an Event to change the Type from domain to domainrenew $package->module_id * OpenSRS 100% completed * Adds the service to the remote server. Sets Input errors on failure, * preventing the service from being added. * * @param stdClass $package A stdClass object representing the selected package * @param array $vars An array of user supplied info to satisfy the request * @param stdClass $parent_package A stdClass object representing the parent service's selected package (if the current service is an addon service) * @param stdClass $parent_service A stdClass object representing the parent service of the service being added (if the current service is an addon service and parent service has already been provisioned) * @param string $status The status of the service being added. These include: * - active * - canceled * - pending * - suspended Does the @params are still evaluated by php if the recommended @params format is not in place? The IBM documentation (as well as phpdoc) seems clear on the fact this may expose your plugin to a security vulnerability. I see this for many functions in the opensrs.php file... ***Also, it seems like the spyc.php version and a couple other libraries that seems to come from the opensrs dev kit and the whmcs module are not up to date with their latest versions. I would suggest to find another way to do things other than by modifying the libraries, so it will make things easier for everyone to upgrade them I see you also commented our a line that seems to secure the opensrs loader file : On line 11 of openSRS_loader.php, i may seems like you forgot i think to remove the comment after testing : //define("OPENSRSURI", dirname(__FILE__)); You module is working fine even if this security is enabled. I saw no problem on this side. I see /api/commands file are modified : public function __construct ($formatString, $dataObject) { parent::__construct($dataObject); Is there any other better way to do this? Another question : do you have an official git where we can push improvements on your plugin? Will you accept those requests? Cheers and thank you for providing us with the module . Carl Quote Link to comment Share on other sites More sharing options...
PauloV Posted June 15, 2015 Author Report Share Posted June 15, 2015 Hi Paulov, please note i do not define myself as a developer (i'm a system administrator). ..but i think i saw a couple of problems with the code. Should may want to take a look at this page : http://www-01.ibm.com/support/knowledgecenter/SSUS3D/com.ibm.wbpm.mon.admin.doc/sec/entitlement_system_sample_interface.html?lang=en you will see it seems like you should be using /** * TODO Create an Event to change the Type from domain to domainrenew $package->module_id * OpenSRS 100% completed * Adds the service to the remote server. Sets Input errors on failure, * preventing the service from being added. * * @param stdClass $package A stdClass object representing the selected package * @param array $vars An array of user supplied info to satisfy the request * @param stdClass $parent_package A stdClass object representing the parent service's selected package (if the current service is an addon service) * @param stdClass $parent_service A stdClass object representing the parent service of the service being added (if the current service is an addon service and parent service has already been provisioned) * @param string $status The status of the service being added. These include: * - active * - canceled * - pending * - suspended ...what i can see in the opensrs module is : /**TODO Create an Event to change the Type from domain to domainrenew $package->module_id* OpenSRS 100% completed * Adds the service to the remote server. Sets Input errors on failure, * preventing the service from being added. * * @param stdClass $package A stdClass object representing the selected package * @param array $vars An array of user supplied info to satisfy the request * @param stdClass $parent_package A stdClass object representing the parent service's selected package (if the current service is an addon service) * @param stdClass $parent_service A stdClass object representing the parent service of the service being added (if the current service is an addon service and parent service has already been provisioned) * @param string $status The status of the service being added. These include: * - active * - canceled * - pending * - suspended Does the @params are still evaluated by php if the recommended @params format is not in place? The IBM documentation (as well as phpdoc) seems clear on the fact this may expose your plugin to a security vulnerability. I see this for many functions in the opensrs.php file... ***Also, it seems like the spyc.php version and a couple other libraries that seems to come from the opensrs dev kit and the whmcs module are not up to date with their latest versions. I would suggest to find another way to do this other than by modifying the libraries, so it will make things easier for everyone to upgrade them I see you also commented our a line that seems to secure the opensrs loader file : On line 11 of openSRS_loader.php, you forgot i think to remove the comment after testing : //define("OPENSRSURI", dirname(__FILE__)); You module is working fine even if this security is enabled. I saw no problem on this side. Another question : do you have an official git where we can push improvements on your plugin? Will you accept those requests? Cheers and thank you for providing us with the module Carl I have to clean the code, the code is not vleaned because is in Alpha Dont tale in count the comments in the code because is based on enom and internebs module so the text comments are iqual Im finishing the Whois Contacts fileds change to relase in 2/3 days activa and Blesta Addons 2 Quote Link to comment Share on other sites More sharing options...
L3Y Posted June 21, 2015 Report Share Posted June 21, 2015 Hi PauloV, Seems like you may have also forgot about the global variables. ...or is it only for the Alpha? ...for example : public function validateConnection($key, $user, $sandbox) { global $connectData; Seems dangerous! If the goal of using global variables in simply to log the module requests, then i invite you to check on the Namecheap and eNom modules : they don't seems to log every requests this way, so i do not think it's absolutely required to leave them in place. Otherwise, opensrs allow us to see the API requests, so there is no need to keep this into Blesta. ...maybe for debugging purpose in Alpha, it's a good idea, but i don't like to have a global for this. I would definitely work on this before the beta version cheers and thank you for your help Carl PauloV 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.