Schedule Service Cancel, Select All Bug

[eldzee]

Hi,

 

whenever an admin tick the select all, and submit services for scheduled cancelation, blesta will throw error

 

Oh noes!

Trying to get property of non-object on line 2114 in {BLESTA}/app/models/services.php

 

Seems like the service_id includes a non-numeric data (from the select all tickbox)

 

POST DATA:

_csrf_token:....
service_ids[]:all
service_ids[]:38
date:2015-10-31
action_type:term
action:schedule_cancellation

I did a quick hack in the /app/controllers/admin_client.php (around line 314), and seems like the problem goes away

private function updateServices($client, array $data) {
...
                    foreach ($data['service_ids'] as $service_id) {
                        // ignore non numeric service_id <'all'>
                        if (!is_numeric($service_id))
                            continue;
                        if ($data['action_type'] == "none") {
                            $this->Services->unCancel($service_id);
                        } else {
                            $this->Services->cancel($service_id, $vars);
                        }
                        $success = true;
                    }
...
}

[Michael]

It worked when I scheduled licenses for customer we don't want to do business with again for me.

[Tyson]

Thanks. CORE-1871

[Michael]

Thanks. CORE-1871

 

Was it if you tick the top box mate as I didn't try that  

[evolvewh]

 

Hi,

 

whenever an admin tick the select all, and submit services for scheduled cancelation, blesta will throw error

 

Just for you Mike........haha!

[Michael]

Just for you Mike........haha!

 

Half read it I ticked the boxes

[Tyson]

This issue will be fixed in v3.6.1 as apart of CORE-1871.