Abdy Posted January 2, 2017 Report Share Posted January 2, 2017 Hi After a lot of work, We want to show to the community one of our actual projects, Advandz Framework, a High-Performance, Fast and Scalable Framework based on minPHP. Why we choose Advandz as a name? Because sounds very similar to "Advanced" and our mission is making one of the most advanced frameworks in the market. At the moment, the framework is in alpha stage, but is fully functional. Quote Link to comment Share on other sites More sharing options...
Mujahed Posted January 2, 2017 Report Share Posted January 2, 2017 What's the difference between it and the minPHP? ... frankly, doesn't look like there is much ..... And the "Advandz-Framework/src/components/download/download.php" component looks exactly like the one that is shipped with Blesta, obviously, this component isn't shipped with the minPHP framework, so its not "Open Source" and its copyrighted, so you cannot re-use it without a permission: https://github.com/Advandz/Advandz-Framework/blob/master/src/components/download/download.php https://github.com/phillipsdata/minphp/tree/master/src/components In general, its just the minPHP framework, with download (which you copied from Blesta), http, hashing, and orm components (did you copy these from somewhere else ?!), which is not enough to make it a different framework. Also the components/files ...etc you took from minPHP, the comments on the top of these files, you shouldn't replace them with your own copyrights !!!!!: https://github.com/Advandz/Advandz-Framework/blob/master/src/components/session/session.php https://github.com/phillipsdata/minphp/blob/master/src/components/session/session.php After a lot of work, We want to show to the community one of our actual projects, Advandz Framework, a High-Performance, Fast and Scalable Framework based on minPHP. Yeah, a lot of "copying" work !!!!!!!! Paul 1 Quote Link to comment Share on other sites More sharing options...
Blesta Addons Posted January 2, 2017 Report Share Posted January 2, 2017 in the fact , the author he already that the framework based on Minphp , normally he is the right to redistribute the package with other name and make some small change . some component is belong to Blesta. others are belong to others but they are Open source . In the past , before we move to blesta 3 , it was a debate in our office which CMS will do for our new website look and engine . we have talked a lot and we have stacked with two choice , symphony or Minphp , but we have diceded to go with minphp to centralize all the work in one platform , and then one of our team has asked what if Minphp was stopped in developing ? that was a critical case that we can a front in the future . Finally we have chosen to work the CMS based on blesta , that way we have opted for a Minphp that is already integrated in blesta , and blesta is top of it, and all our website will be centralized in one administration . after almost one year, we found we have opted for the best solution, and be along from Minphp was a good choice , as we see now Minphp is stopped from update publicly , and now blesta is shipped with Minphp v1 that is not available for public at the moment . and we think is almost impossible to make it publicly and allow people to make pull request or suggesting any other feature, as the blesta team the first thing they need to see if the request will be negative aspect for blesta . for my point of view , Minphp should be the internal framework of blesta, and why not another framework that is based on it to be for the public . but attention to copyrights , regarding Advandz, i can call it the public version of Minphp , but it has some thing that should be fixed . 1 - the plugin system will not work, because the engine of it doesn't exist. (take a look at componenets/plugins in blesta . 2 - Namespacing is not used in this framework, is better to add the new Minphp components and load them via autoloader . 3 - Lock of docs, how you can connect the framework to database, how to use the components, helpers, ect ... i liked the idea of the cdnjs.php helper class , and the components type.php . Quote Link to comment Share on other sites More sharing options...
Mujahed Posted January 2, 2017 Report Share Posted January 2, 2017 1 hour ago, Blesta Addons said: in the fact , the author he already that the framework based on Minphp , normally he is the right to redistribute the package with other name and make some small change . some component is belong to Blesta. others are belong to others but they are Open source . I don't think so ... at least not entirely true, the component I mentioned is the download/download.php, have a look at the license comment on the top of that file in your blesta, and you will find that the license is not an open source, yet the source code is open: blesta.com/license Other than that component, yeah they're open source (minPHP). My criticism was about them being the same as the original framework (minPHP) but with a different name and few new files/components and new copyrights (for the same exact code/files ...etc) Quote Link to comment Share on other sites More sharing options...
Blesta Addons Posted January 2, 2017 Report Share Posted January 2, 2017 10 minutes ago, Mujahed said: I don't think so ... at least not entirely true, the component I mentioned is the download/download.php, have a look at the license comment on the top of that file in your blesta, and you will find that the license is not an open source, yet the source code is open: blesta.com/license Totally agreed with you . 10 minutes ago, Mujahed said: Other than that component, yeah they're open source (minPHP). My criticism was about them being the same as the original framework (minPHP) but with a different name and few new files/components and copyrights (for the same exact code/files ...etc) It worth add a new line in each file mentioned that the whole code was token from Minphp Quote Link to comment Share on other sites More sharing options...
Abdy Posted January 2, 2017 Author Report Share Posted January 2, 2017 Hi, The actual minPHP code in GitHub not works, due this we have made a dump directly from Blesta 3 for extract the working minPHP Framework, We will review the code in search of Blesta code and remove then. Advandz is not only a soft modification of minPHP, Advandz will be shipped in the final version with more components, a Stack, Control Panel and a Hack Version. Quote Link to comment Share on other sites More sharing options...
Mujahed Posted January 2, 2017 Report Share Posted January 2, 2017 22 minutes ago, cyandark said: Hi, Advandz is not only a soft modification of minPHP, Advandz will be shipped in the final version with more components, a Stack, Control Panel and a Hack Version. 2 That's alright, in the open source world it is normal for someone to fork an open source project and build on top of it or modify it (MySQL & MariaDB, OwnCloud & NextCloud) , however, when you use a code that is written by others, you must keep the copyrights/license of the original developer and not change it to your own, and only put your own copyrights/license to the files/code you wrote , e.g: - NextCloud which is a fork of OwnCloud,(server/apps/dav/lib/CalDAV/Plugin.php) : https://github.com/nextcloud/server/blob/6a75296ccbd37d11f88f1e69cfe4063a802c438c/apps/dav/lib/CalDAV/Plugin.php - OwnCloud's File (core/apps/dav/lib/CalDAV/Plugin.php): https://github.com/owncloud/core/blob/master/apps/dav/lib/CalDAV/Plugin.php Paul and Blesta Addons 2 Quote Link to comment Share on other sites More sharing options...
Abdy Posted January 2, 2017 Author Report Share Posted January 2, 2017 The copyright has been updated and we pulled out 2 files that matches with Blesta 3 Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
Paul Posted January 4, 2017 Report Share Posted January 4, 2017 Interesting thread. Sounds like it's sorted. I'll add though, the minPHP framework is not exclusively used for Blesta, and when we update it we take that into consideration. minPHP is used for many different projects, and the goal of minPHP is to keep it minimal. A fork of minPHP with significant changes/improvements is welcomed so long as it doesn't contain any code from Blesta that is not released under MIT. Michael 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.