Hi PauloV,
Thank you for the new version, however, there still seems to be missing validations...
I see a lot of things like this one :
$callArray[$contactType]["address1"] = $this->osrs_normalize_special_characters($client->address1);
$callArray[$contactType]["address2"] = $this->osrs_normalize_special_characters($client->address2);
$callArray[$contactType]["address3"] = "";
$callArray[$contactType]["city"] = $client->city;
$callArray[$contactType]["state"] = $client->city;
$callArray[$contactType]["postal_code"] = $client->zip;
$callArray[$contactType]["country"] = $client->country;
$callArray[$contactType]["email"] = $client->email;
$callArray[$contactType]["phone"] = $this->formatPhone(isset ($numbers[0]) ? $numbers[0]->number : null, $client->country);
$callArray[$contactType]["fax"] = "";
$callArray[$contactType]["url"] = "";
$callArray[$contactType]["lang_pref"] = "EN";
You sanitize with pregmatch in the function "osrs_normalize_special_characters" only address1 and address2, but not address3, and all other fields will send whatever you type.
The module do not seems to validate what's sent to the opensrs API.
The validateConnection should be private, since it work as private, and not required to be public. There is a couple other functions like this.
I would strongly suggest to review the module before using it.
I did not verified to see if the domain lock functions got improved, so the customers can see if yes or no a domain is locked or unlocked, but i may check on this within the next few days and get back if there is still a problem...
Cheers,
Carl