Hotfix for 4.9.0+ for autodebit

[Jono]

A bug was introduced in 4.9.0 that causes the autodebit cron job to ignore the autodebit setting on an individual client in favor of the client group or company setting.  This only occurs when the client setting is false and one of the others is true.  This issue can be resolved by modifying app/models/invoices.php Invoices::getClientSettingSubquery() and replacing:

        $this->Record->select()
            ->from([
                '((' . $sql1 . ') UNION (' . $sql2 . ') UNION (' . $sql3 . ') UNION (' . $sql4 . '))' => 'temp'
            ]);

With

        $this->Record->select()
            ->from([
                '((' . $sql1 . ') UNION (' . $sql2 . ') UNION (' . $sql3 . ') UNION (' . $sql4 . '))' => 'temp'
            ])
            ->group('temp.client_id');

 

[jwogrady]

Was experiencing this issue. I've applied the fix. Will report back tomorrow after the cron runs.  Thank you so much for finding and fixing this. You guys are the best!