Supposed Bug: License Module

[serge]

Warning: array_merge(): Argument #2 is not an array in /home/demo-woocommerce/public_html/wp-content/plugins/xxxxx-for-woocommerce/class.php on line 184

 

it's the third Blesta license server integration I do and each time at client side, when license key is wrong, there this php warning;

 

it's come from this below part in the original file /plugins/license_manager/dist/license_manager.php

 

Note that in my integration this file name was changed.

			unset($data['status']);
			return array_merge(
				array(
					'status' => $status,
					'label' => null,
					'time' => null,
					'allow_reissue' => null,
					'addons' => null,
					'version' => null,
					'custom' => null
				),
				$data   
			);   // THIS IS LINE 184 IN MY RENAMED FILE
		}

As having a customer using a wrong license key is just one of common case, i expect not having any php warning.

[serge]

Bump

 

I know the reported error only come when there is PHP error reporting enabled at client side, but it will be fine to do not have such warning

[Cody]

I see the issue.

 

In some cases LicenseManager::decryptData can't decrypt the data, so it returns null. When null is unserialized it returns boolean false.

 

Added CORE-1643.

 

We'll work on a fix. Thanks!