mas.satriyo Posted June 13, 2016 Report Share Posted June 13, 2016 Hi, i found modulesbakery's digitalocean module for blesta in github tried to install the module, it could connect to digitalocean api, could get my ssh keys (as global ssh keys) and get droplets size (ram size, but only 512MB, 1GB and 2GB) tried to make dummy order, i could create order and saved to blesta database but it couldn't create real droplets in digitalocean, even couldn't store user's ssh key i know modulesbakery had stopped the development of this module, but does this module still compatible with latest blesta version? if need some modification, anyone can tell me which part i have to modify? thanks a lot brianlv3 1 Quote Link to comment Share on other sites More sharing options...
Paul Posted June 13, 2016 Report Share Posted June 13, 2016 Are there any errors in the module log under Tools > Logs: Module tab? Click the table row for an entry to expand and show the raw input/output Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted June 13, 2016 Author Report Share Posted June 13, 2016 Validating Client SSH Key 1500 - ketupat.satriyowibowo.my.id s:15:"sshkey_validate"; the only log just ssh key validation module seems like 'doing nothing' Quote Link to comment Share on other sites More sharing options...
Paul Posted June 13, 2016 Report Share Posted June 13, 2016 I'm not very familiar with the DO module, what action are you performing that makes that API request, and what is the ssh key used for? I would assume it would be for console access, is it used for provisioning? If you have an order that is waiting for provisioning, you should have a "pending" service. On the client's profile, click on "Pending" for services, and then "Manage" and try to activate manually. Is there any error output? Quote Link to comment Share on other sites More sharing options...
timnboys Posted June 14, 2016 Report Share Posted June 14, 2016 I'm not very familiar with the DO module, what action are you performing that makes that API request, and what is the ssh key used for? I would assume it would be for console access, is it used for provisioning? If you have an order that is waiting for provisioning, you should have a "pending" service. On the client's profile, click on "Pending" for services, and then "Manage" and try to activate manually. Is there any error output? I could take a look at it and try to fix it since well I have some digitalocean credit to use before you know it expires since I got it from the github student pack. Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted June 14, 2016 Author Report Share Posted June 14, 2016 I'm not very familiar with the DO module, what action are you performing that makes that API request, and what is the ssh key used for? I would assume it would be for console access, is it used for provisioning? If you have an order that is waiting for provisioning, you should have a "pending" service. On the client's profile, click on "Pending" for services, and then "Manage" and try to activate manually. Is there any error output? the order already 'active' in client's account but no droplet created in my digitalocean account I could take a look at it and try to fix it since well I have some digitalocean credit to use before you know it expires since I got it from the github student pack. you can download the module here https://github.com/blesta/module-digitalocean extract to /blesta-directory/components/module rename folder to digitaloceanmodule create composer.json and put { "name": "blesta/digitaloceanmodule", "description": "DigitalOcean", "license": "proprietary", "type": "blesta-module", "require": { "blesta/composer-installer": "~1.0" } } i figure out this method by trial and error extract the zip from github directly, and install the module directly, blesta can't find the module digitaloceanmodule wasn't in the available list Quote Link to comment Share on other sites More sharing options...
Paul Posted June 14, 2016 Report Share Posted June 14, 2016 I could take a look at it and try to fix it since well I have some digitalocean credit to use before you know it expires since I got it from the github student pack. If you're willing to do that, great.. feel free to submit a pull request with your changes for review and inclusion. https://github.com/blesta/module-digitalocean Quote Link to comment Share on other sites More sharing options...
timnboys Posted June 14, 2016 Report Share Posted June 14, 2016 If you're willing to do that, great.. feel free to submit a pull request with your changes for review and inclusion. https://github.com/blesta/module-digitalocean okay great I will just fork your repo to one on github for me to then merge the changes back that I will make to make it work again to you. Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted June 15, 2016 Author Report Share Posted June 15, 2016 when i tried to create new order from client side, it couldn't add new ssh-key to my do account but when i tried to add from admin side, it could add new ssh-key but couldn't create service and this error appears "You specified an invalid image for Server creation." i'm sure that this module really need updates, since it couldn't list available images, locations, list additional options, or choose one-click apps ----edit------- i think many functions are missing Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted August 19, 2016 Author Report Share Posted August 19, 2016 On 6/15/2016 at 2:55 AM, timnboys said: okay great I will just fork your repo to one on github for me to then merge the changes back that I will make to make it work again to you. hi, can you re-create this DO module? i think paid module is okay Quote Link to comment Share on other sites More sharing options...
bunny Posted August 20, 2016 Report Share Posted August 20, 2016 DO module has a problem with Blesta 3.4. up. I checked, works excellent on 3.2.2 INUMIO-Rob 1 Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 23, 2016 Report Share Posted August 23, 2016 On 8/19/2016 at 10:53 AM, mas.satriyo said: hi, can you re-create this DO module? i think paid module is okay yes if you are willing for a paid module that is okay I can do that....as to be honest if I had to rewrite everything from scratch and didn't get to turn it into a paid module for the time and work I spent on it I don't think me in that situation nor anyone else would like/be happy with that lol. Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted August 29, 2016 Author Report Share Posted August 29, 2016 On 8/23/2016 at 9:58 AM, timnboys said: yes if you are willing for a paid module that is okay I can do that....as to be honest if I had to rewrite everything from scratch and didn't get to turn it into a paid module for the time and work I spent on it I don't think me in that situation nor anyone else would like/be happy with that lol. never use modulesbakery's digitalocean module, but can you code the module which looks like hypnoticmonkey's whmcs digitalocean module? it's really user and admin friendly pm me the cost and it's 'license agreement' Quote Link to comment Share on other sites More sharing options...
Paul Posted August 29, 2016 Report Share Posted August 29, 2016 On 8/20/2016 at 2:46 PM, SiXwishlist said: DO module has a problem with Blesta 3.4. up. I checked, works excellent on 3.2.2 Do you know why it's incompatible with 3.4+? I'm not aware of any backwards incompatible changes in the module system. Unless, perhaps, the module is doing something out of the ordinary. The best way forward is to fix this existing module. @timnboys do you know what the compatibility issue is with 3.4+? We are slammed with 4.0. I'll donate $50 for a pull request that resolves the issue. (Please test test test before submitting) Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
JNdev Posted August 29, 2016 Report Share Posted August 29, 2016 ++ for blesta if can fix DO module. DO best solution for hoster without buy DC. Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 30, 2016 Report Share Posted August 30, 2016 7 hours ago, Paul said: Do you know why it's incompatible with 3.4+? I'm not aware of any backwards incompatible changes in the module system. Unless, perhaps, the module is doing something out of the ordinary. The best way forward is to fix this existing module. @timnboys do you know what the compatibility issue is with 3.4+? We are slammed with 4.0. I'll donate $50 for a pull request that resolves the issue. (Please test test test before submitting) Working on the fix right now. Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
mas.satriyo Posted August 30, 2016 Author Report Share Posted August 30, 2016 4 hours ago, timnboys said: Working on the fix right now. as i tried before, the digitalocean api php file was the problem Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 30, 2016 Report Share Posted August 30, 2016 12 hours ago, mas.satriyo said: as i tried before, the digitalocean api php file was the problem yes and I am working on that fix right now as it wasn't the api php file the problem it was do_api_test.php and the module's php file doing the wrong/outdated calls to digitalocean's api. Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 30, 2016 Report Share Posted August 30, 2016 On 8/29/2016 at 1:51 PM, Paul said: Do you know why it's incompatible with 3.4+? I'm not aware of any backwards incompatible changes in the module system. Unless, perhaps, the module is doing something out of the ordinary. The best way forward is to fix this existing module. @timnboys do you know what the compatibility issue is with 3.4+? We are slammed with 4.0. I'll donate $50 for a pull request that resolves the issue. (Please test test test before submitting) Hello Paul @Paul here is the fixed module & pull request: https://github.com/blesta/module-digitalocean/pull/2 I will take that $50 now lol. Blesta Addons 1 Quote Link to comment Share on other sites More sharing options...
Paul Posted August 30, 2016 Report Share Posted August 30, 2016 2 hours ago, timnboys said: Hello Paul @Paul here is the fixed module & pull request: https://github.com/blesta/module-digitalocean/pull/2 I will take that $50 now lol. I commented on some of your changes in your pull request.. I'll ask Tyson to review also, so there may be more. Thanks! Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 30, 2016 Report Share Posted August 30, 2016 18 minutes ago, Paul said: I commented on some of your changes in your pull request.. I'll ask Tyson to review also, so there may be more. Thanks! okay I just fixed the issues you commented on. Quote Link to comment Share on other sites More sharing options...
timnboys Posted August 31, 2016 Report Share Posted August 31, 2016 It looks like I am still waiting for @Tyson and @Paul to find anything else wrong with my code before they will finally merge it. JNdev 1 Quote Link to comment Share on other sites More sharing options...
Rocketz Posted August 31, 2016 Report Share Posted August 31, 2016 Nice work guys. It's good to see this kind of collaboration Paul 1 Quote Link to comment Share on other sites More sharing options...
Jono Posted September 9, 2016 Report Share Posted September 9, 2016 Just finished reviewing @timnboys code and we should get that merged soon. Please let us know if you encounter other problems with the module. Michael, austenite and Blesta Addons 3 Quote Link to comment Share on other sites More sharing options...
austenite Posted September 9, 2016 Report Share Posted September 9, 2016 4 minutes ago, Jono said: Just finished reviewing @timnboys code and we should get that merged soon. Please let us know if you encounter other problems with the module. Great, super excited for this! Any idea of an ETA when downloads of the module will be made available? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.